Problem/Motivation

Steps to reproduce

Proposed resolution

Change comments to remove references to Olivero.

Uses not change here

core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php - do in a new issue concerning remaining tests
Search is about to be deprecated and removed, so leave these is Search

  • core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroRemoveBlockConsoleTest.js
  • core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php

core/tests/Drupal/Nightwatch/Tests/Claro/claroPrimaryTabsTest.js - A valid comment that states the file came from Olivero. This will leave core when Claro is removed.

Remaining tasks

Review
Commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3617523

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16742

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

Linting is passing an this is only changing comments, so setting for a review.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Applied the suggestions to use Default Admin over claro.

I did use AI to help with the grep command grep -rni "olivero" /var/www/html/core --include="*.php" --include="*.twig" --include="*.yml" | grep -v "/themes/olivero/" | grep -E "\s*(//|#|\*|{\s*#)"

This still gets findings but reviewing them it appears to be related to tests are being removed/moves in other tickets.

May need one final lap at the very end.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Tiny grammar nitpick; I think "an SVG" is correct over "a SVG"!

quietone’s picture

quietone commented
Status: Needs work » Needs review

@longwave, thanks for the suggestions. I applied the suggestions.

Linting passed on this doc only MR so setting to needs review.

@smustgrave, not sure about that grep command. It is not searching the entire repository and is only searching a few file extensions. We do have comments in *.js and *.module etc. And there is a usage in a JSON file as well.
git grep -ni olivero | grep -v core/assets | grep -v core/themes/olivero | grep -E "\s*(//|#|\*|{\s*#)"

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Running that I get

core/modules/block/tests/src/Functional/NonDefaultBlockAdminTest.php:48:    // Ensure that the Olivero tab is shown.
core/modules/block/tests/src/Kernel/ConfigActionsTest.php:116:  #[TestWith(["placeBlockInDefaultTheme", "olivero", "header"])]
core/modules/block/tests/src/Kernel/ConfigActionsTest.php:145:  #[TestWith(["placeBlockInDefaultTheme", "olivero"])]
core/modules/config/tests/src/Functional/ConfigImportUITest.php:101:    // Olivero ships with configuration.
core/modules/config/tests/src/Functional/ConfigImportUITest.php:108:    // Set the Olivero theme as default.
core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php:57:   * The olivero theme ships core.date_format.olivero_medium with langcode
core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php:62:    // Install olivero via the Appearance UI.
core/modules/locale/tests/src/Functional/LocaleThemeInstallTest.php:70:    // core.date_format.olivero_medium ships with langcode 'en'. Locale's
core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php:180:      // @todo Add coverage for olivero after fixing
core/modules/node/tests/src/Functional/NodeDisplayConfigurableTest.php:182:      // ['olivero', 'footer', TRUE],
core/modules/package_manager/tests/src/Kernel/StagedDBUpdateValidatorTest.php:42:    // Olivero are not installed, so they are used to test what happens when
core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php:22:    // Install required module for the Olivero front page.
core/modules/search/tests/src/Nightwatch/Tests/Olivero/TestSiteOliveroInstallTestScript.php:29:    // Install Olivero and set it as the default theme.
core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroRemoveBlockConsoleTest.js:18:          .click('[href*="olivero_search_form_narrow/disable"]')
core/modules/search/tests/src/Nightwatch/Tests/Olivero/oliveroRemoveBlockConsoleTest.js:24:          .click('[href*="olivero_search_form_wide/disable"]');
core/modules/system/tests/modules/olivero_test/src/Hook/OliveroTestThemeHooks.php:10: * Hook implementations for olivero_test.
core/modules/system/tests/modules/olivero_test/src/Hook/OliveroTestThemeHooks.php:30:    $variables['#attached']['library'][] = 'olivero_test/log-errors';
core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php:84:    // displayed in the admin theme and olivero.
core/modules/system/tests/src/Functional/System/ThemeTest.php:278:    // Visit Olivero's theme settings page to replace the logo.
core/modules/system/tests/src/Functional/System/ThemeTest.php:302:    // Install the Olivero theme.
core/modules/system/tests/src/Functional/System/ThemeTest.php:321:    // Visit Olivero's theme settings page.
core/modules/system/tests/src/Functional/System/ThemeTest.php:355:    // Save Olivero's theme settings which should invalidate the 'rendered'
core/modules/system/tests/src/Functional/System/ThemeTest.php:459:    // Install Olivero and set it as the default theme.
core/modules/system/tests/src/Functional/System/ThemeTest.php:504:    // Install olivero.
core/modules/system/tests/src/Functional/System/ThemeTest.php:515:    // Set olivero as the default theme.
core/modules/system/tests/src/Functional/System/ThemeTest.php:519:    // Check that olivero cannot be uninstalled as it is the default theme.
core/modules/system/tests/src/Functional/System/ThemeTest.php:538:    // Check that olivero can be uninstalled now.
core/modules/system/tests/src/Functional/System/ThemeTest.php:541:    // Uninstall each of the two themes starting with Olivero.
core/tests/Drupal/Nightwatch/Tests/Claro/claroPrimaryTabsTest.js:1:// This test is a duplicate of oliveroPrimaryTabsTest.js tagged for claro
core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php:23:    // Install required module for the Olivero front page.
core/tests/Drupal/TestSite/TestSiteClaroInstallTestScript.php:28:    // Install Claro instead of Olivero and set it as the default theme.

Spot checking a few I think they're related to tests. So may be good to do one more lap after all the tests land too.

quietone’s picture

quietone commented
Assigned: Unassigned » quietone
Status: Reviewed & tested by the community » Postponed

Rebased and postponing. I need to do some move searching but that will have to wait until tomorrow.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Assigned: quietone » Unassigned
Status: Postponed » Needs review

This is in better shape now. Linting has passed so setting to needs review.