Problem/Motivation

Making the home page Stories section dynamic in #3616545 added two Views block displays to this recipe's recipe.yml: a featured display for views.view.news and a latest display for views.view.events, about three hundred and eighty lines in total.

Neither belongs here. This is a site template; the news view is owned by Varbase News Base and the events view is reshaped by Varbase Events Base. Defining the displays in the site template means no other consumer of those recipes can use them, and the recipe carries several hundred lines of view configuration it should never have owned. The exported displays also carried vartheme_bs5_educare: component ids, which only work on this template's theme.

Proposed resolution

Move both displays to the recipes that own their views, and remove them from here:

  • views.view.news featured → Varbase News Base (#3616585);
  • views.view.events latest → Varbase Events Base (#3616587).

Both ship with the base theme's component ids, and this recipe's existing setViewsComponentStyleTheme actions repoint them to vartheme_bs5_educare at install, exactly as they already do for every other display. The Home page keeps the two Views blocks it places; only the display definitions move.

This issue depends on both of the above being merged and released first.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ❌ Release notes snippet
  • ✅ Release educare-1.0.0-alpha2

User interface changes

  • None. The Stories section renders exactly as before.

API changes

  • N/A

Data model changes

  • The two block displays now arrive from Varbase News Base and Varbase Events Base rather than from this recipe.

Release notes snippet

  • The Stories block displays now come from Varbase News Base and Varbase Events Base, so they can be reused outside this site template.

Issue fork educare-3616588

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 6b1cb8e7 on 1.0.x
    refactor: #3616588 Move the Stories view displays to Varbase News Base...

  • rajab natshah committed 3634b02c on 1.0.x
    ci: #3616588 Stop the Drupal CMS job republishing the shared build cache
    
rajab natshah’s picture

Assigned: Unassigned » josebc
Issue summary: View changes
Status: Active » Needs review
Issue tags: +educare-1.0.0-alpha2
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.