DrupalConsoleLogger::log() passes $message to strtr() without casting it to string. PSR-3 allows Stringable messages. TranslatableMarkup is one. That causes:
TypeError: strtr(): Argument #1 ($string) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup
\Drupal::logger('test')->warning(new TranslatableMarkup('Value %v is invalid.'), ['%v' => 'x']);
Cast $message to string before placeholder replacement.
| Comment | File | Size | Author |
|---|---|---|---|
| core-03-console-logger-stringable-message.patch | 906 bytes | luigisa |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
luigisa commentedComment #3
smustgrave commentedFixes need to be in MRs and as a bug test coverage
Comment #4
quietone commentedHi, thanks for the issue and the patch! Issues for Drupal core should be targeted to the 'main' branch, our primary development branch. Changes are made on the main branch first, and are then back ported as needed according to the Core change policies. The version the problem was discovered on should be stated in the issue summary Problem/Motivation section. Thanks.
If AI was used in any way to created the issue or the fix The Drupal policy is that the use must be stated on the issue. Refer to the policy on the use of AI when contributing to Drupal includes that the use of AI must be disclosed.
The needs an MR to be ready for review.
Comment #5
quietone commentedUpdating the title per Title guidelines.
Comment #7
luigisa commentedComment #8
luigisa commentedComment #9
smustgrave commentedCan we extend an existing test vs adding a new one. Also can the AI verbosness be cleaned up and written in your own wording?
Comment #10
luigisa commentedComment #11
luigisa commentedMoved the coverage into ConsoleTest instead of a new test class. Also trimmed the comments and the issue summary.
Thanks @smustgrave for your comment
Comment #12
luigisa commentedComment #13
smustgrave commentedSo I checked
Psr\Log\LoggerTraitand it hasString|\Stringableas a typehint. So I think we need to add here too but because of BC we can't. Think the best route would be to check the $message variable is not Stringable trigger a deprecation that in D13 it will be required.Comment #15
zeeshan_khan commentedComment #16
zeeshan_khan commentedDisclosure: AI was used to investigate and find better solution then manually reviewed and fixed the issue
Comment #17
idebr commentedBumped into this error when upgrading a project from Drupal 10 to Drupal 11.
The issue is fixed with the change suggested in https://git.drupalcode.org/project/drupal/-/merge_requests/16704
To my understanding, the deprecation should link to a change record and not the issue itself according to https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...
Actionable items: