Problem/Motivation

The phpstan CI job fails on the 3.1.x branch: ConfigEntityBase::trustData() is deprecated in Drupal 11.4 with no replacement, and is still called in includes/helpers.inc and src/Form/VarbaseWorkflowSettingsForm.php.

Steps to reproduce

Run the phpstan job on the branch pipeline.

Proposed resolution

  • Drop the trustData() calls and save the roles directly.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ❌ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Removed the deprecated trustData() calls from the role permission grants.

AI-Generated: Yes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 8ea28176 on 3.1.x
    fix: #3615805 Resolve the PHPStan findings raised by the updated...
rajab natshah’s picture

Status: Active » Fixed
Issue tags: +varbase_workflow-3.1.2

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue tags: +varbase-10.1.2
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.