Problem/Motivation

The phpstan CI job fails on the 10.1.x and 9.2.x branches: the updated phpstan-drupal analyzers raise drupal.hookEntityOperationMissingCacheabilityParameter on the pre-existing entityOperation() hook in src/Hook/VarbaseApiHooks.php.

Steps to reproduce

Run the phpstan job on the branch pipeline.

Proposed resolution

  • Add the cacheability parameter to the entity-operation hook and record the user-permissions cache context and the module settings config as cacheable dependencies.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ❌ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The View JSON entity operation now records its cacheability.

AI-Generated: Yes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed bb0cffed on 9.2.x
    fix: #3615801 Resolve the PHPStan findings raised by the updated...

  • rajab natshah committed 45d804d7 on 10.1.x
    fix: #3615801 Resolve the PHPStan findings raised by the updated...
rajab natshah’s picture

Issue tags: +varbase-9.2.1
rajab natshah’s picture

Issue tags: -varbase-9.2.1
rajab natshah’s picture

✅ Released varbase_api-9.2.2

rajab natshah’s picture

Issue summary: View changes
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue tags: +varbase_api-10.1.2

✅ Released varbase_api-10.1.2

rajab natshah’s picture

Issue tags: +varbase-10.1.2
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.