Problem/Motivation

The phpstan CI job fails on the 4.0.x, 3.1.x and 3.0.x branches: the updated phpstan-drupal analyzers raise drupal.symfonyYamlParse on pre-existing code in src/EventSubscriber/ActiveThemeChangeSubscriber.php.

Steps to reproduce

Run the phpstan job on the branch pipeline.

Proposed resolution

  • Use \Drupal\Component\Serialization\Yaml::decode() / Yaml::encode() instead of the Symfony YAML parser and dumper, and catch InvalidDataTypeException.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ❌ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ✅ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Modernized the YAML handling in the active-theme change subscriber to the Drupal serialization component.

AI-Generated: Yes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 139fb4fa on 4.0.x
    fix: #3615796 Resolve the PHPStan findings raised by the updated...

  • rajab natshah committed 82bee811 on 3.1.x
    fix: #3615796 Resolve the PHPStan findings raised by the updated...

  • rajab natshah committed 6472c79a on 3.0.x
    fix: #3615796 Resolve the PHPStan findings raised by the updated...
rajab natshah’s picture

Status: Active » Fixed
Issue tags: +varbase_components-3.1.1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue tags: +varbase-10.1.2
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Issue tags: +varbase-11.0.0-rc1

✅ Released varbase-11.0.0-rc1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.