Problem/Motivation
The phpstan CI job fails on the 4.0.x, 3.1.x and 3.0.x branches: the updated phpstan-drupal analyzers raise drupal.symfonyYamlParse on pre-existing code in src/EventSubscriber/ActiveThemeChangeSubscriber.php.
Steps to reproduce
Run the phpstan job on the branch pipeline.
Proposed resolution
- Use
\Drupal\Component\Serialization\Yaml::decode()/Yaml::encode()instead of the Symfony YAML parser and dumper, and catchInvalidDataTypeException.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ❌ Readability
- ➖ Accessibility
- ➖ Performance
- ➖ Security
- ➖ Developer Documentation
- ➖ User Guide Documentation
- ➖ Reviewed by human
- ➖ Code review by maintainers
- ➖ Full testing and approval
- ➖ Credit contributors
- ➖ Review with the product owner
- ➖ Release notes snippet
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Modernized the YAML handling in the active-theme change subscriber to the Drupal serialization component.
AI-Generated: Yes
Issue fork varbase_components-3615796
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #8
rajab natshah✅ Released varbase_components-3.1.1
Comment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshah✅ Released varbase_components-4.0.0-rc1
Comment #13
rajab natshah✅ Released varbase-11.0.0-rc1