Problem/Motivation

The site template declares its post-install redirect with a leading slash in recipe.yml:

extra:
  finish_url: /admin/dashboard/welcome

Core's install_goto() prepends the base path, so the leading slash is doubled and the browser installer sends the user to https://example.com//admin/dashboard/welcome.

This recipe value, not the profile's, is the one that fires: Varbase's SiteTemplateForm::submitForm() copies the site template's extra.finish_url into $install_state['parameters']['finish_url'], so the installer URL carries finish_url=/admin/dashboard/welcome.

drupal_cms_installer declares the same value without a leading slash, which is the convention to match.

Steps to reproduce

  1. Build a Varbase 11 project with the Educare site template available in recipes/.
  2. Go to /core/install.php and pick Educare.
  3. Complete the installer.
  4. The browser lands on //admin/dashboard/welcome instead of /admin/dashboard/welcome.

Proposed resolution

Drop the leading slash:

extra:
  finish_url: 'admin/dashboard/welcome'

Verified on a browser install: the installer URL then carries finish_url=admin/dashboard/welcome and the site lands on the correct path with no doubled slash.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ❌ Reviewed by human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ❌ Release notes snippet
  • ❌ Release

User interface changes

  • After finishing the browser installer the site lands on /admin/dashboard/welcome rather than //admin/dashboard/welcome.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Fixed the post-install redirect landing on a doubled slash.

Issue fork educare-3614796

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed d653c1aa on 1.0.x
    fix: #3614796 Remove the leading slash from the site template finish_url
    
rajab natshah’s picture

Assigned: Unassigned » josebc
Status: Active » Needs review
Issue tags: +educare-1.0.0-alpha1
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.