Problem/Motivation

The header menu did not match the design, in two ways.

  1. The design orders the links About, Resources, Programs, Countries, Events, Donate. The shipped weights put Events before Countries.
  2. "Events" appeared twice in the header, and the call-to-action pill read "Events" instead of "Donate". The Events view shipped its own main-menu link (views_view:views.events.page_1) at weight 0, duplicating the curated menu link. The theme renders the last main-menu item as the call-to-action pill (last_item_is_cta, set in the theme's menu--main.html.twig), so that stray weight-0 link took the pill.

Steps to reproduce

  1. Install the Horizon Aid site template on Varbase 11 (Drupal ~11.4).
  2. Load the front end and inspect the header main menu.

Observed: Events sorts before Countries, and "Events" appears twice, once as the call-to-action pill.

Proposed resolution

  • Swap the two shipped menu link weights so Countries (-46) sorts before Events (-45), matching the design order About, Resources, Programs, Countries, Events, Donate.
  • Turn off the Events view's own menu link (display.page_1.display_options.menu.type: none on views.view.events) so it stops duplicating the curated Events link and stops taking the call-to-action pill. Donate then falls last on its own and becomes the pill, with no special-casing.

Verified on a Varbase 11 site in a browser: the header renders About, Resources, Programs, Countries, Events, then Donate as the gold pill with the 20px radius, and Events appears once. The rendered menu tree is Home(-50, disabled) → About(-49) → Resources(-48) → Programs(-47) → Countries(-46) → Events(-45) → Donate(0).

Note for reviewers: the golden reference site still shows the older Events-before-Countries order and the same duplicate link, so this follows the design rather than that site.

AI-Generated: Yes

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • Header main menu order now matches the design (Countries before Events); the call-to-action pill now targets Donate instead of the stray duplicate Events link.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The header main menu now matches the design; the duplicate "Events" link and mislabeled call-to-action pill are fixed.

Issue fork horizonaid-3614658

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 7cfaf779 on 1.0.x
    fix: #3614658 Order the header menu to the design and drop the duplicate...
rajab natshah’s picture

Assigned: Unassigned » josebc
Status: Active » Needs review
Issue tags: +horizonaid-1.0.0-alpha1
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.