Problem/Motivation

The change in #3579782: Exclude disabled links before loading menu tree has caused an unexpected behaviour on our site where children of disabled parent links are now rendering in the menu, essentially at the first level, in place of their parent.

Steps to reproduce

  1. Place a SF block with "Expand all items" and more than one level
  2. Create a top level link that is disabled, with children links that are enabled
  3. See the child links are rendered in the menu

Proposed resolution

Would you consider reverting this to seek a solution that doesn't cause this behaviour? We could work around it by revamping the menu or by changing the config not to expand all links, but I can't imagine we are the only ones who will hit this.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3614590-children-of-disabled.patch725 bytesdkmishra

Issue fork superfish-3614590

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

dkmishra made their first commit to this issue’s fork.

dkmishra opened merge request !27

dkmishra changed the visibility of the branch 3614590-children-of-disabled to hidden.

dkmishra’s picture

dkmishra commented
StatusFileSize
new 3614590-children-of-disabled.patch725 bytes

Patch attached.

dkmishra’s picture

dkmishra commented
Version: 2.0.x-dev » 8.x-1.x-dev
Status: Active » Needs review
pameeela’s picture

pameeela commented
Status: Needs review » Needs work

This should be an MR, not a patch, and it's not really helpful to just revert the change -- the module maintainer needs to weigh in on how they would like to handle this. They may decide not to fix, since it could be considered a misconfiguration I guess.

Ideally, the change can remain in place without the unexpected side effect.

dkmishra’s picture

dkmishra commented

MR is already up at !27 - the patch in #5 is just the exported diff from that fork branch for convenience. Happy to adjust the approach if the maintainer prefers something different. Thank you!

ivnish made their first commit to this issue’s fork.

ivnish opened merge request !28

ivnish’s picture

ivnish
he/him
commented
Assigned: Unassigned » ivnish
ivnish’s picture

ivnish
he/him
commented
Assigned: ivnish » Unassigned
Status: Needs work » Needs review

lobsterr’s picture

lobsterr commented
Status: Needs review » Fixed

Thank you for your contribution

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • ivnish committed 9e36b92f on 2.0.x 
    Resolve #3614590 "Children of disabled fix"

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.