Problem/Motivation

It's very slow https://git.drupalcode.org/project/drupal/-/jobs/11171389

192.417s Drupal\Tests\media\Kernel\MediaAccessControlHandlerTest                  61 passed

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613253

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16447

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Left 1 comment on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Trait may be overkill will let committer decide though.

  • longwave committed 5baee171 on main 
    test: #3613253 Split up MediaAccessControlHandlerTest

By: catch
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Regarding the trait this is certainly not the only place that we assert cache metadata and perhaps it's worth an issue somewhere to clean it up/provide a unified assertion, but out of scope for this issue, duplicating the code once seems fine as it is.

Committed and pushed to main, thanks! Did not backport cleanly, not sure it's worth the effort.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.