Problem/Motivation

Looks like some copy-paste issue in the BC layer: https://git.drupalcode.org/project/drupal/-/blob/11.4.x/core/lib/Drupal/...

This results in a fatal when a caller invokes the constructor without the new $fast_cache argument, e.g. a decorator service configured via Symfony autowiring, since $fast_cache has no type-hint and therefore cannot be autowired.

Main is not affected naturally.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613047

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

graber created an issue. See original summary.

berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It's not a copy paste mistake, it's the normal approach for inserted arguments, so if someone would have provided them before it would be the language manager. However, what it account for is that it has a default value and the arguments were already optional.

berdir opened merge request !16438

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 11.4.x-dev » 11.x-dev
Status: Active » Needs review

This doesn't need to go into main but we need a separate issue for that to remove the BC layer there.

s_leu’s picture

s_leu commented
Status: Needs review » Reviewed & tested by the community

Tested and works well.

  • longwave committed 9cd9d24c on 11.4.x 
    fix: #3613047 RouteProvider::__construct() BC branch assigns $table to $...

  • longwave committed 081865f9 on 11.x 
    fix: #3613047 RouteProvider::__construct() BC branch assigns $table to $...

  • longwave committed 6c17be9d on main 
    fix: #3613047 RouteProvider::__construct() BC branch assigns $table to $...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Decided to keep this in main to keep things in sync and save someone possibly re-discovering it when they come to remove the deprecation later.

Committed and pushed 6c17be9d892 to main and 081865f9d44 to 11.x and 9cd9d24c28e to 11.4.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.