Problem/Motivation

The 🧪 Automated Functional Testing job in .gitlab-ci.yml temporarily pinned drupal/varbase_components to the issue-fork branch of Varbase Components issue #3611182, because the components_exposed_form views exposed-form plugin (which the events listing view uses) was not yet in Varbase Components 4.0.x.

That merge request, Varbase Components !46, is now merged. The plugin resolves from 4.0.x-dev now, so the pin must go, otherwise CI keeps building from a stale issue fork.

Steps to reproduce

  1. Open .gitlab-ci.yml on the 1.0.x branch of Varbase Events Base.
  2. Look at the 🧪 Automated Functional Testing job.
  3. See the six-line TEMPORARY comment block plus the repositories.varbase_components_fork VCS repository line, and the pinned drupal/varbase_components:dev-3611182-components-exposed-form as 4.0.x-dev argument in the composer require retry loop.

Proposed resolution

Remove the TEMPORARY comment block and the repositories.varbase_components_fork line, and drop the pinned drupal/varbase_components argument from the composer require retry loop, so that drupal/varbase_components resolves from 4.0.x-dev again — the same version stream the merged Varbase Components !46 (issue #3611182) landed on.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase_events_base-1.0.0-alpha1

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 6a025459 on 1.0.x
    ci: #3611860 Remove the temporary Varbase Components issue-fork pin from...
rajab natshah’s picture

Assigned: Unassigned » josebc
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase_events_base-1.0.0-alpha1
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Issue summary: View changes
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.