Problem/Motivation

On the Events listing view, the card-dated-vertical, pagination, and views-exposed-filters components do not match the design (VBE Stylesheet, node 12050:6856, "events-listing-view"):

  • The dated card used a uniform 24px padding (Bootstrap p-4), but the design specifies 32px block / 24px inline padding.
  • The pager rendered flat 20px/700 gray page numbers with no active state: items were not sized/centered as 40×40 boxes, the active page had no highlight, the previous/next/first/last controls were not circular, and the number color did not match the design's navy.
  • The exposed filters form (layout already fixed in #3611876 / MR !15) still used the wrong visual tokens: the label color, the placeholder/input text color and size, the input/select border-radius, and the Apply Filter / Reset button casing did not match the design.

Steps to reproduce

Visit an Events listing page (/events) on a site built with this theme and compare the dated cards, the pager, and the exposed filters form against the design (VBE Stylesheet, node 12050:6856).

Proposed resolution

  • Add a padding: 32px 24px; rule to .card-dated-vertical in card-dated-vertical.scss so the card matches the design's block/inline spacing, overriding the p-4 utility class applied in the twig.
  • In pagination.scss: size every .page-link as a 40×40 centered box; set the page-number font to 16px / weight 500 / line-height 1.35; color the numbers navy (var(--bs-dark), #050833); fill the active page with a cream circle (var(--bs-secondary-bg-subtle), #f8f3ed, border-radius 50%); make the previous/next/first/last arrow controls circular (var(--bs-border-radius-pill, 50rem)); and dim disabled arrows to 50% opacity.
  • In views-exposed-filters.scss (visual-token follow-up to the layout fix in #3611876 / !15): color labels with var(--bs-tertiary-color) (#212529); color placeholder/input/select text with the theme's $subtle-text token (#404456) at 14px; set the input/select border-radius to var(--bs-border-radius-sm) (4px, was 8px); and uppercase the Apply Filter / Reset button text.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase_events_base-1.0.0-alpha1

User interface changes

  • The events listing dated card now has 32px top/bottom and 24px left/right padding (was 24px uniform).
  • The pager numbers/arrows are now 40×40 boxes; the active page shows a cream circular highlight; the previous/next/first/last controls are circular; page numbers are navy 16px/500 instead of gray 20px/700.
  • The exposed filters labels are darker, the input/select text is smaller and a dark-subtle color, the input/select corners are less rounded, and the Apply Filter / Reset buttons render in uppercase.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Version: » 1.0.x-dev

  • rajab natshah committed 318b594d on 1.0.x
    fix: #3610873 Install Vartheme BS5, which the recipe's Canvas templates...

  • rajab natshah committed 0874550b on 1.0.x
    fix: #3610873 Drop the Industry filter and name the exposed filters...

  • rajab natshah committed d9bc6cc2 on 1.0.x
    feat: #3610873 Grant event content and taxonomy permissions to the...

  • rajab natshah committed 40b1cf11 on 1.0.x
    test: #3610873 Add a Varbase functional testing suite for the Varbase...

rajab natshah’s picture

Fresh installs of the events recipe were 500ing (PluginNotFoundException on the smartdate field type) because this recipe's own config (smartdate_default/smartdate_inline formatters, field.field.node.event.field_when) depends on smart_date, but only the events sub-recipe was bringing the module in. MR !8 adds smart_date to this recipe's own install list to make the dependency explicit: https://git.drupalcode.org/project/varbase_events_base/-/merge_requests/8

Note: this does not by itself fix the 500 — there's a separate smart_date 4.3.0 / core 11.4.4 container bug being handled separately.

rajab natshah’s picture

Issue summary: View changes

Matched the events listing exposed Search filter's label/placeholder to the VBE Stylesheet design (Figma node 12050:6856) in MR !10: https://git.drupalcode.org/project/varbase_events_base/-/merge_requests/10

  • rajab natshah committed fec827a1 on 1.0.x
    fix: #3610873 Match the events listing exposed-filter labels to the...

  • rajab natshah committed 174b4f7c on 1.0.x
    task: #3610873 Repoint the events exposed form to the site default theme
    
rajab natshah’s picture

Assigned: rajab natshah » josebc
Status: Active » Needs review
Issue tags: +varbase_events_base-1.0.0-alpha1
rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.