Problem/Motivation

The module installs did_this_help.settings with a question key, and both the settings form and block read/write question. However, the config schema defines message instead of question. This leaves the actual question configuration without matching schema.

--------------------------------- ---------------- ------------- ------ 
  Key                               Status           Validatable   Data  
 --------------------------------- ---------------- ------------- ------ 
  did_this_help.settings:question   missing schema                       
 --------------------------------- ---------------- ------------- ------

Steps to reproduce

1. Install Drupal 11.
2. Install and enable Did this help? 2.0.8.
3. Run: drush config:inspect --detail --only-error

Proposed resolution

Change the schema mapping from message to question:

did_this_help.settings:
  type: config_object
  label: 'Did this help? config'
  mapping:
    question:
      type: string
      label: 'Question'
    no_answers:
      type: string
      label: '"No" answers'

Issue fork did_this_help-3610074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dkmishra created an issue. See original summary.

dkmishra opened merge request !6

dkmishra’s picture

dkmishra commented
Assigned: dkmishra » Unassigned
Status: Active » Needs review

  • 913edef8 committed on 2.0.x 
    Issue #3610074: Fixed schema issue
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)
dkmishra’s picture

dkmishra commented

Hi @levmyshkin, thanks for committing the fix.

I noticed I wasn't credited for this issue. Since I reported the issue and also created the merge request that was committed, would you mind adding issue credit for my contribution if you think it's appropriate?

Thank you!