Follow-up to the Project Update Bot issue #3598063, done with test coverage and CI verification rather than only declaring compatibility.

Problem

The module declares core_version_requirement "^10.3 || ^11" and does not test against the next major version in CI (OPT_IN_TEST_NEXT_MAJOR is commented out in .gitlab-ci.yml), so Drupal 12 compatibility is unverified. The field formatter also has no automated test coverage.

Proposed resolution

  • Enable OPT_IN_TEST_NEXT_MAJOR in .gitlab-ci.yml so the pipeline runs against the next major version.
  • Add "^12" to core_version_requirement once the next-major job passes.
  • Add kernel test coverage for the field formatter (target="_blank" added or omitted per the add_target_blank setting, rel attributes, and the new-window message), which currently has none.

Remaining tasks

  • Confirm the next-major (Drupal 12) job is green in CI.
  • Review the added test coverage.

Issue fork external_link_a11y-3608762

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !11

mably’s picture

mably commented
Status: Active » Needs review

MR !11 is green, including the next-major (Drupal 12) jobs: after enabling OPT_IN_TEST_NEXT_MAJOR, composer, phpstan and phpunit all pass against Drupal 12. So the "^12" core_version_requirement is now backed by a real Drupal 12 test run, not only a Rector scan. The MR also adds kernel test coverage for the field formatter, which previously had none. Supersedes the Project Update Bot issue #3598063.

  • mably committed 9a54a6a8 on 1.x 
    task: #3608762 Add Drupal 12 compatibility, enable next-major CI testing...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.