Problem/Motivation

Drupal 11 introduced object-oriented hook implementations via the #[Hook] attribute (change record). Varbase Search targets Drupal ~11.4.0, so converting the procedural hooks to an OOP hook class improves structure and aligns with core.

Steps to reproduce

Proposed resolution

Move hook_form_entity_view_display_edit_form_alter() from varbase_search.module into src/Hook/VarbaseSearchHooks.php with a #[Hook] attribute. The form submit callback stays procedural (referenced by name). No #[LegacyHook] wrapper is needed on the 11.4-only branch.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release varbase-9.2.0, varbase_search-9.2.0

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • task: #3608316 Convert the procedural hooks to OOP hook classes in the Varbase Search module
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed d7796b3a on 10.1.x
    task: #3608316 Convert the procedural hooks to OOP hook classes in the...

  • rajab natshah committed 3cf0f601 on 9.2.x
    task: #3608316 Convert the procedural hooks to OOP hook classes in the...
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Fixed
Issue tags: +varbase-9.2.0, +varbase_search-9.2.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.2.0

rajab natshah’s picture

Version: 10.1.x-dev » 9.2.x-dev
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.