Problem/Motivation

Add gitlab-ci.yml (template) to make CI run on the project

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork adminlte-3607152

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody opened merge request !1

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Add gitlab-ci.yml » Add gitlab-ci.yml and fix tests, cspell, eslint, phpstan, stylint
Status: Needs review » Needs work
Issue tags: +Novice
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: » 1.0.x-dev
Assigned: Unassigned » grevil

@grevil let's try to auto-fix what's possible and makes sense.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Oh no, why is this branch 9 commits behind? 🥺

grevil’s picture

grevil commented

I'll revert all the changes again and reapply them, I'll kill myself rebasing this.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Issue tags: -Novice

Yea, no chance...

@silkalns Please do not simply push commits like https://git.drupalcode.org/project/adminlte/-/commit/398066b5dcd2773e4a8... without any review or no related issue!!!

anybody opened merge request !4

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

grevil changed the visibility of the branch 3607152-gitlab-ci-rebase to hidden.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

https://git.drupalcode.org/project/adminlte/-/pipelines/881677 still issues so needs work

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

I think we should not remove CHANGELOG.md for AI reasons of the maintainer ;)

grevil’s picture

grevil commented
Status: Needs work » Needs review

I think we should not remove CHANGELOG.md for AI reasons of the maintainer

Hard disagree, the current changelog already contains old informations, and we shouldn't adjust it on every commit.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned

Great now Drupal Gitlab completely gave up...

Let's please tag a new release and merge this afterwards, if I have to waste one more minute on this wonderful and beautiful issue, I have to go out and pick some flowers in the backyard! 😊