Problem/Motivation

The constructor of the recently introduced update MailHandler class accepts a $time argument. But that isn't used anywhere in the class. Remove it.

Steps to reproduce

Proposed resolution

Remove it. Best would be before 11.4 is released.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3606709

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

znerol created an issue. See original summary.

znerol’s picture

znerol commented
Status: Active » Needs review
znerol’s picture

znerol commented

Note, this isn't touching any released code. If it gets committed before 11.4, then there is no need to deprecate the removed constructor argument.

znerol opened merge request !16157

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Looks good, I don't see it being used and it's new to 11.4.

godotislate closed merge request !16157

  • godotislate committed 07dd1f81 on 11.4.x 
    task: #3606709 Remove superflous  property from update MailHandler

By:...

  • godotislate committed b3251112 on 11.x 
    task: #3606709 Remove superflous  property from update MailHandler

By:...

  • godotislate committed dfeb89a0 on main 
    task: #3606709 Remove superflous  property from update MailHandler

By:...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed dfeb89a to main, b325111 to 11.x, and 07dd1f8 to 11.4.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.