Problem/Motivation

In the issue https://git.drupalcode.org/project/ai_initiative/-/work_items/3585696#no... where this recipe was suggested it was requested to depend on https://www.drupal.org/project/drupal_cms_media . But that recipes has so many unrelated dependencies. The real dependency that this recipe needs is core image media type recipe (core/recipes/image_media_type) that is also a dependency for drupal_cms_media.

I believe if the core/recipes/image_media_type is used it will be possible to cover broader audience including the one that uses Drupal CMS.

Issue fork ai_recipe_validations_image_safety-3595519

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

a.dmitriiev commented
Assigned: Unassigned » a.dmitriiev

a.dmitriiev opened merge request !1

a.dmitriiev’s picture

a.dmitriiev commented
Status: Active » Needs review
a.dmitriiev’s picture

a.dmitriiev commented
Assigned: a.dmitriiev » Unassigned

Actually this MR also fixes the problem that it is not possible to fetch this recipe with composer:

- drupal/ai_recipe_validations_image_safety 1.0.x-dev requires drupal/drupal_cms_media ^1.0 -> found drupal/drupal_cms_media[2.0.0-beta1, ..., 2.x-dev] but it does not match the constraint.

As it depends on drupal_cms_media ^1.0 that doesn't exist anymore (see here https://www.drupal.org/project/drupal_cms_media/releases)

ahmad-khalil-imagex’s picture

ahmad-khalil-imagex
He/Him
Primary language English
Location London, Ontario, Canada
commented
Assigned: Unassigned » ahmad-khalil-imagex

  • a.dmitriiev committed b9938de1 on 1.0.x 
    Issue #3595519: Depend on core media image type recipe
a.dmitriiev’s picture

a.dmitriiev commented
Assigned: ahmad-khalil-imagex » Unassigned
Status: Needs review » Fixed
Issue tags: +AI Initiative Sprint, +AI Product Development

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

ahmad-khalil-imagex’s picture

ahmad-khalil-imagex
He/Him
Primary language English
Location London, Ontario, Canada
commented
Status: Fixed » Closed (fixed)