Problem/Motivation

Child of #3584794: [meta] Convert core routes to PHP attributes

Steps to reproduce

Proposed resolution

Routing definitions for Views UI controllers will be moved to attributes on the controller where possible.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3593666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !15986

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Maybe we want to wait for the form routing issue to land and expand on this.

smustgrave’s picture

smustgrave commented

Maybe add the 1 route that's in views too?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Convert views_ui routes to attributes » Convert Views routes to attributes

Added views.ajax route.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Nice! Think that's a good grouping.

smustgrave’s picture

smustgrave commented

Actually saw your comment on the META this looks good but do you want to postpone?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs review

Converted the two forms as well.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I reviewed the whole MR and didn't note any problems. The form route moves look good. I loaded up both the basic and advanced views settings forms in the browser. There were no issues. The MR looks good to me.

  • godotislate committed 99884a64 on 11.x 
    task: #3593666 Convert Views routes to attributes

By: longwave
By:...

  • godotislate committed 70c6a37f on main 
    task: #3593666 Convert Views routes to attributes

By: longwave
By:...
godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 70c6a37 to main and 99884a6 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.