Problem/Motivation

In #3572350: Disable the default /node listing view and add a better default front page for new installs we are making /node not even enabled by default. It is already a configurable view that may or may not be the front page. So the "promoted to front page" feature is immediately confusing and a lie when /node is not the front page. But that issue makes that the default experience that /node will not be the front page. So the name of that feature will immediately not be true.

Steps to reproduce

Proposed resolution

Because that issue already changes a lot of things, decided to break out this terminology change to its own issue. #3572350: Disable the default /node listing view and add a better default front page for new installs renames the "Frontpage" view to the "Promoted content" view, so the "promoted" checkbox / feature aligns with that. This rename is better for all sites where the /node is not the front page (which is most sites), regardless of whether #3572350: Disable the default /node listing view and add a better default front page for new installs happens or not.

Remaining tasks

User interface changes

When creating content type:

When managing content type form:

When adding content:

When editing the /node view (without any other core changes applied):

Introduced terminology

API changes

Data model changes

Release notes snippet

The "Promoted to front page" feature is now renamed to "Promoted".

LLM disclosure

LLM was used to accelerate the development of this MR, everything was deeply reviewed though.

Issue fork drupal-3593281

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy’s picture

Issue summary: View changes
gábor hojtsy’s picture

Issue summary: View changes
Status: Active » Needs review

Adding LLM disclosure as I did use LLM to generate the MR. I reviewed all changes line by line and also independently grepped my Drupal checkout after creating the changes that there seem to be no mention of promotion in relation to front page left in the codebase.

Please review :)

gábor hojtsy’s picture

gábor hojtsy’s picture

Issue summary: View changes

Typo in release note snippet made it sound like the opposite of what is happening :D

gábor hojtsy’s picture

Issue summary: View changes

Updated issue summary with explanation of terminology and lack of API changes and data model changes, which is a big plus IMHO :)

gábor hojtsy’s picture

Issue summary: View changes
gábor hojtsy’s picture

Issue summary: View changes
StatusFileSize
new491.68 KB
macsim’s picture

Status: Needs review » Needs work

Super small comment but this is looking good to me.

smustgrave’s picture

Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

Applied the MR locally

Searched for the phrase "Promote to front page" using grep -rE 'Promote to (the )?front page' core
Verified field on a content type is called Promoted

This is a nice little cleanup.

For the template change since it's a comment not sure if it needs a CR? Going to mark regardless.

macsim’s picture

Applied the 2 suggestions I had left on the MR to improve consistency with the rest of the changes
RTBC+1

macsim’s picture

I might be wrong but I think we need a Change Record for this issue. Several user-facing translatable strings have been renamed. On non-English sites, existing translations for these strings will no longer match and will fall back to English. Site owners with custom translations and translation teams on localize.drupal.org need to be aware of these changes.

  • 'Promoted to front page' → 'Promoted' (Node.php, NodeTypeForm.php)
  • 'Promoted to front page status' → 'Promoted status' (NodeViewsData.php)
  • 'A boolean indicating whether the node is visible on the front page.' → 'A boolean indicating whether the node is promoted.' (NodeViewsData.php)
  • 'Promote selected content to front page' → 'Promote selected content' (PromoteNode.php)
  • 'Demote selected content from front page' → 'Unpromote selected content' (DemoteNode.php)
  • 'You haven't created any frontpage content yet.' → 'You haven't created any promoted content yet.' (get-started.html.twig)
  • 'Promote content to front page' → 'Promote content' (system.action.node_promote_action.yml)
  • 'Remove content from front page' → 'Unpromote content' (system.action.node_unpromote_action.yml)
  • 'All content promoted to the front page.' → 'All promoted content.' (views.view.frontpage.yml)
  • 'No front page content has been created yet.' → 'No promoted content has been created yet.' (views.view.frontpage.yml)
gábor hojtsy’s picture

I created a change record based on the list you provided converted to a HTML table to make it easier to read :) https://www.drupal.org/node/3593641 I don't know if this would be backported to 11.5 or not, I think the impact depends on that. We can easily update the change record though :)

catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x - I think it makes sense to backport, less time to maintain two versions of the translation and keeps tests in sync.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 0644c252 on 11.x
    task: #3593281 Rename "promoted to front page" to "promoted"
    
    By: gábor...

  • catch committed 234a5ae4 on main
    task: #3593281 Rename "promoted to front page" to "promoted"
    
    By: gábor...

berdir’s picture

Happy with this change, it did bypass some other open issues and discussions there though. There is #3538655: Remove promote/sticky fields from Node which is only 10 months old and a follow-up of the 20 year old and now fixed #29338: Hide Promoted/Sticky fields by default in Form display. I'll cross-reference this, I still think we should keep those two fields.

catch’s picture

I still think we should keep those two fields.

Yes me too at least until there's a way to put configurable boolean fields on entity base tables or something along those lines.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.