Problem/Motivation

phpstan/phpstan has a new minor release, https://github.com/phpstan/phpstan/releases/tag/2.2.0

See also https://phpstan.org/blog/phpstan-2-2-unsealed-array-shapes-safer-array-keys

Proposed resolution

  1. composer update mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit spaze/phpstan-disallowed-calls
  2. update manually the constraints to latest versions
  3. composer update --lock

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3592506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !15914

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Don't see issues here. All is green, its a bugfix release and improvements in detections, which seems also result in some extra ignores.

I think this is fine.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

Will need an 11.x backport.

catch closed merge request !15914

  • catch committed 314a5ed8 on main 
    task: #3592506 Bump PHPStan to 2.2.0

By: mondrake
By: bbrala

mondrake opened merge request !15947

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Patch (to be ported) » Needs review

backported

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I compared the 11.x diff to the one that was committed to main. They're identical with the exception of the composer.lock hash. I cloned the 11.x MR and tested running composer install. There were no issues. The backport looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.4.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 33e66e55 on 11.x 
    task: #3592506 Bump PHPStan to 2.2.0

By: mondrake
By: bbrala
By: catch...

  • catch committed 417b6ae4 on 11.4.x 
    task: #3592506 Bump PHPStan to 2.2.0

By: mondrake
By: bbrala
By: catch...

mondrake closed merge request !15947

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.