Problem/Motivation

The security advisory coverage application received review feedback that should be addressed in the module codebase before continuing the application review.

This issue groups the technical cleanups and modernization tasks required to better align the module with current Drupal contrib expectations.

Steps to reproduce

  1. Review the security advisory coverage application feedback.
  2. Inspect the module codebase.
  3. Identify the technical changes requested for contributed project readiness.

Proposed resolution

  • Remove or replace version: VERSION in paragraphs_usage_manager.libraries.yml, because VERSION is reserved for Drupal core libraries.
  • Move procedural hooks from paragraphs_usage_manager.module to object-oriented hooks where appropriate.
  • Update configuration forms extending ConfigFormBase to use #config_target where possible.
  • Update the minimum supported Drupal core version if required by the configuration form changes.
  • Add GitLab CI configuration using the Drupal Association GitLab CI template.
  • Run the relevant checks and fix any failures reported by GitLab CI.

Remaining tasks

  • Update library definitions.
  • Refactor hooks where appropriate.
  • Refactor configuration forms to use #config_target.
  • Update Drupal core compatibility if needed.
  • Add .gitlab-ci.yml.
  • Run tests and CI checks.
  • Update the security advisory coverage application issue once the changes are merged.

User interface changes

None expected. Existing configuration pages should keep the same user-facing behavior.

API changes

No public API changes expected.

Data model changes

No data model changes expected.

Issue fork paragraphs_usage_manager-3591703

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nono95230 created an issue. See original summary.

nono95230 opened merge request !4

nono95230’s picture

nono95230 commented
Status: Active » Needs review

A merge request has been created.

It addresses technical feedback from the security advisory coverage application review, including library definition cleanup, configuration form modernization, object-oriented hook refactoring, GitLab CI setup, and Drupal core compatibility updates.

  • nono95230 committed f50db622 on 1.2.x 
    Issue #3591703: Address security coverage review feedback
nono95230’s picture

nono95230 commented
Status: Needs review » Fixed

Released in 1.2.0.

This issue is now included in an official release.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

nono95230’s picture

nono95230 commented
Status: Fixed » Closed (fixed)

Released in 1.2.0.

The issue has been fixed, merged, and included in an official release.