Problem/Motivation

Similar to #3587776: Support all entity types but I am missing support for block_content entities.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 canvas_140.png23.44 KBpeter törnstrand
#6 canvas_133.png22.12 KBpeter törnstrand

Issue fork canvas_entity_reference-3590586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

peter törnstrand created an issue. See original summary.

peter törnstrand opened merge request !11

peter törnstrand’s picture

peter törnstrand commented
Status: Active » Needs review

First run at this. Also updated the documentation in README.md.

peter törnstrand’s picture

peter törnstrand commented

I'm missing something, getting the value entity:node/1 in the autocomplete widget after selecting a match. Had it working an hour ago.

peter törnstrand’s picture

peter törnstrand commented
Issue tags: +Needs tests
peter törnstrand’s picture

peter törnstrand commented
StatusFileSize
new canvas_133.png22.12 KB
new canvas_140.png23.44 KB

I figured it out. I was running version 1.3.3 of the Canvas module in my first environment where I tested this.

When creating the MR in a different environment I was on version 1.4.0. It seems the 1.4.x version of Canvas breaks all types of reference fields defined by this module. Instead of returning the label for the entity an URI is returned, for example entity:node/1 and this does not get processed correctly in the UI.

So I guess it has something to do with the normalization of the selected autocomplete value back to the scalar integer expected by the Canvas prop.

peter törnstrand’s picture

peter törnstrand commented
Related issues: +#3590655: Not compatible with Canvas 1.4.0 / 1.4.1
zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Needs work

Thanks for the contribution @peter tornstrand! The approach is correct — adding block_content to REF_URI_TO_ENTITY_TYPE, updating schema.json, and adding a matches test is exactly the right pattern.

A few things to fix before we can merge:

1. The Twig template test-block-content-id.twig has copy-paste errors from the
node-id component — it still references article_id, the badge shows
x-entity-field: nid, and the heading says "Node Reference". These should all
be updated to reflect block_id and block_content.
2. It would be good to add a testApplyBlockContentEntityType() kernel test
alongside the matches test, to verify the handler settings and label key
resolve correctly for block_content (the label key is info).
3. Please also double-check whether the block module needs to be listed in
$modules in the test — block_content may be self-sufficient without it.

zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs work » Needs review

Thanks @peter tornstrand! The approach is correct. I've pushed a follow-up commit to your branch fixing the copy-paste errors in the Twig template (article_id -> block_id, wrong badge text, heading, and CSS modifier class) and adding testApplyBlockContentEntityType() to verify the handler settings and label key (info) resolve correctly for block_content.

kleve’s picture

kleve commented

The patch does not apply to the latest version 1.0.3.

zeeshan_khan’s picture

zeeshan_khan commented

@kleve Thanks for the report. The block_content entity support (including the tests) was merged and released in 1.0.3. Please update your module to 1.0.3 and the feature should be available without needing to apply any patch.

You can update via Composer:

composer require drupal/canvas_entity_reference:^1.0
composer update drupal/canvas_entity_reference

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Tahnks @zeeshan_khan - looks like this is fixed then?

zeeshan_khan’s picture

zeeshan_khan commented

yes @julian if you can RTBC this one we can close it :) thanks

zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Reviewed & tested by the community

Based on the last comment by @julian marking this to Fixed!
Feel free to re-open or create new issue if the issue persist anymore.

zeeshan_khan’s picture

zeeshan_khan commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.