Problem/Motivation

From #3567225: Allow per-node override of Content Template via checkbox in node selector #20 by @belkin13:

It's very easy to accidentally reset the override settings. (perhaps a confirmation dialog should be added?)

Might also make sense for CSRF reasons?

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A

Issue fork canvas_override-3590567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » rajab natshah

rajab natshah opened merge request !4

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
Related issues: +#2158943: Add a native dialog element using HTMX to deprecate the jQuery UI dialog

Thank you very much @rajab natshah - code-wise this already looks VERY good!

Now that also this uses the jQuery UI dialog indirectly, I'd once again like to promote pushing #2158943: Add a native dialog element using HTMX to deprecate the jQuery UI dialog forward to get rid of that.

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Add a confirmation dialog for the reset » Add a confirmation before resetting a Canvas layout
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @rajab natshah - implementation LGTM.

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Needs work

rajab natshah reopened merge request !4

  • rajab natshah committed fcb822b6 on 1.0.x 
    feat: #3590567 Add a confirmation step before resetting a Canvas layout
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs work » Active
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Active » Fixed

✅ Released canvas_override-1.0.0-rc1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.