Problem/Motivation

graphql_compose is not compatible with graphql 5.0.0-rc1 because of breaking API changes introduced since beta3:

  • getSchema() no longer accepts a ResolverRegistryInterface $registry parameter.
  • getSchemaDefinition() must now return a GraphQL\Language\Source object instead of a plain string.
  • getBaseDefinition() and getExtensionDefinition() in ResolverOnlySchemaExtensionPluginBase now return ?Source instead of ?string.
  • AlterSchemaDataEvent and AlterSchemaExtensionDataEvent now expect preparsed DocumentNode objects instead of raw strings.

Steps to reproduce

  1. Require drupal/graphql at 5.0.0-rc1.
  2. Enable graphql_compose.
  3. Load any GraphQL schema and see PHP fatal errors.

Proposed resolution

Apply the attached patch.

Remaining tasks

  • Review and test against graphql 5.0.0-rc1.
  • Merge once approved.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
graphql_compose-graphql5-rc1-api-compatibility.patch4.47 KBcamvertiz

Issue fork graphql_compose-3590358

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

camvertiz created an issue. See original summary.

camvertiz’s picture

camvertiz commented
Related issues: +#3587491: Upstream 5.0.0-beta3 changes

almunnings made their first commit to this issue’s fork.

almunnings opened merge request !153

almunnings’s picture

almunnings
Location Melbourne, 🇦🇺
commented
Version: 3.0.0-alpha2 » 3.0.x-dev
Category: Support request » Task
Priority: Normal » Critical
Status: Active » Needs review

OOOOkkkkay, deprecations on `callback()` all replaced with some slop. Created new producers for everything.

Whilst fixing up producers, View's `label` prop now resolves to the View display title instead of the entity title.
Per #3539592: Add View title to GraphQL Compose query results it's now `title` not `label` in Views GraphQL results.

Tests all pass D10/D11, with the exception of one smart date test next minor, which seems unrelated and more of an upstream issue.

Seems like its good to go (until the next breaking changes)
Can you please run a quick sanity test on this, and we'll get the alpha cut.

camvertiz’s picture

camvertiz commented

Tested the MR branch on a D11 site running drupal/graphql 5.0.0-rc1. All GraphQL queries working as expected, no regressions found. The compatibility issue is resolved. LGTM, ready for the alpha cut.

Thank you for taking the time to work through this and get it sorted!

almunnings’s picture

almunnings
Location Melbourne, 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

  • almunnings committed fe8564c9 on 3.0.x 
    fix: #3590358 Upstream 5.0.0-rc1 compatibility changes
almunnings’s picture

almunnings
Location Melbourne, 🇦🇺
commented

Thanks for testing!

I’ll have some time tomorrow afternoon to do the release and double triple check the extra producers.

almunnings’s picture

almunnings
Location Melbourne, 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Alpha 3 released, thank you

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.