Problem/Motivation

Symfony already provide a symfony/polyfill-php86 package with helpful new functionalities (clamp() and SortDirection enum ATM)

Steps to reproduce

https://wiki.php.net/todo/php86

Proposed resolution

add symfony/polyfill-php86 to core's compsoer

Remaining tasks

patch, CR and commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3590237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !15763

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Updated previous CR https://www.drupal.org/node/3464803

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Reviewed & tested by the community
dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Needs review

Is it worth changing anything in core to use at least one of the new functions as part of this issue? So we see that tests still pass, and so we see what kinds of improvements the new functions would unlock? Otherwise, seems this is adding an unused dependency, and the release managers tend not to like doing that. 😅

mstrelan’s picture

mstrelan commented

We've had some of these polyfills go in on their own in the past, and they have proven useful particular for back ports, e.g. an MR targeting 11.x could use PHP 8.3 functions and backport easily to 10.x. It also makes it easier for contrib to use new language features. IMHO we should get this in without finding usages.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Makes sense to me. I’m all for it, was only trying to channel my inner release manager. 😂 change is simple enough and looks good. Bot is happy (as expected). Let’s see what a committer thinks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Allow use PHP 8.6 functions » Add PHP 8.6 polyfill
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed 0d464ba79b0 to main. Thanks!

  • alexpott committed 0d464ba7 on main 
    task: #3590237 Add PHP 8.6 polyfill

By: andypost

andypost closed merge request !15763

andypost opened merge request !15784

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Patch (to be ported) » Needs review

created 11.x MR

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c78fd35 and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed c78fd35c on 11.x 
    task: #3590237 Add PHP 8.6 polyfill

By: andypost

andypost closed merge request !15784

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.