Deprecate and replace locale_status related functions

Just copying some comments from the MR of [#] so I can mark them as resolved:

--

this calls get_status() with an array of a single project and langcode, which gets all project data from key value, if it doesn't exist it calls buildSources() again from within the loop on projects and langcodes, which again loops over the exactly one project and langcode and calls sourceBuild(). which always returns something, so the layers of isset() checks are meaningless. what on earth were we doing when we added this code in 2013.
on the plus side, this now already injects the LocaleSource service in this, so if we merge the translation status methods into LocaleSource then this already has the service for that.

--

didn't review closely yet, but was a bit surprised to see one of the batch methods access this key value store directly. This seems to bypass locale_translation_get_status() as that always builds non-existing info?
maybe we can explicitly not inject keyvaluestore and incorporate that use case into the replacement repository service for translation status stuff? (which is another concept/value structure that apparently not even that function knows what it means seems to be tightly coupled to LocaleSource, loadSources(), which is unused in core, seems to call that, so sources == translation status?). it is also highly inefficient, as it always unconditionally does a loadAll() on the key value store.

--

re the comment on sources vs status, this also apparently calls the translation status sources/a source (unrelated to this, just taking notes that maybe all that belongs into the LocaleSource service and we can merge those API's together)

The blocker is in, I've already started on the MR but it's very much WIP.

I haven't managed to reproduce that one fail locally, but it does seem persistent. Can you reproduce that one?

I think there's no pending feedback on the MR. Did some updates to CR and summary to explain a bit more what we're changing and why.

Seems OK to do the deprecations in a follow-up, as you say there's plenty going on here already.

Committed/pushed to main, thanks!

This will need a backport MR for 11.x/11.4.x

Are there changes that need to back into main?

Went ahead and backported this to 11.4 - there's a tiny chance of annoying someone now, vs. a larger chance of annoying someone later + guaranteed more work. Hopefully this turns out to be the right choice.

Moving to main to forward port the 11.x changes there.

I think #28 didn't mean to change version/status.

We discussed those additional test fails in slack. They end up being identical, as all tests now use the exact version string the installer, so we already remove the dev version here.

They didn't fail on 11.x because they are skipped there.

See also #3594389: Remove unecessary core dev version replacement in locale project info which I've already created earlier today before we found that one. We no longer end up with the kind of version strings that this test was using because we changed the structure of Drupal::VERSION in 2024.

I think LocaleNonInteractiveInstallTest also doesn't add anything useful anymore, it just tests that the translation from the .po file is imported and used, that's what InstallerTranslationMultipleLanguageTest and subclasses do as well and we could completely remove that one too, but lets discuss that in a follow-up, this is already doing way too much. We can also backport the removal of the removal of the subclass to 11.x there. Opened #3594914: Remove LocaleNonInteractiveInstallTest

Committed/pushed to main, thanks!

This broke 11.4.x installer tests

Time: 00:12.389, Memory: 12.00 MB

There was 1 failure:

1) Drupal\FunctionalTests\Installer\InstallerTranslationTest::testInstaller
Behat\Mink\Exception\ResponseTextException: The text "Save and continue de" was not found anywhere in the text of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:907
/var/www/html/vendor/behat/mink/src/WebAssert.php:293
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:981
/var/www/html/core/tests/Drupal/FunctionalTests/Installer/InstallerTranslationTest.php:127

I've reverted the 11.4.x commit (left it in 11.x). We can either add everything back + the fix in 11.4, or worst case this becomes 11.5+ only - but if it's reverted it unblocks other bugfixes going into 11.4 etc.

Sorry, that's my fault. I thought I tested that.

I wasn't aware that we *do* still use the major.minor.patch-dev format on minor branches. I checked git history, but only on the main branch and there it doesn't show up of course.

This is essentially #3594389: Remove unecessary core dev version replacement in locale project info. The problem is that the regular expression mentioned there matches on 11.4.0-dev and converts the expected filename to 11.4.x, and then that doesn't match Drupal::VERSION anymore.

I verified that drupal.org supports this format and redirects:

curl -I https://ftp.drupal.org/files/translations/all/drupal/drupal-11.4.0-dev.de.po
HTTP/2 302 
server: nginx
content-type: text/html
location: https://ftp.drupal.org/files/translations/all/drupal/drupal-11.4.x.de.po

To fix this, we have two options:

a) We remove the regex in the two places where it appears, so we always use the exact version string of Drupal::VERSION for core, then it's predictable.
b) Or we keep it, then we need a wrapper/helper/something to apply that same version mangling to the ~20 tests that generate the .po filename.

I'm slightly confused about the linked #3445211: Composer tests fail because of invalid Drupal version in my issue. why was 11.0.0-dev a problem but 11.4.0-dev is OK?

I created a combined MR with the revert of the revert and the removal of the two regular rexpressions for semver versions. Tested manually with standard, umami, local and remote translation files on 11.4.x-dev and InstallerTranslationTest.php.

your call if we're going to backport this. If not, I'll move the regex changes to #3594389: Remove unecessary core dev version replacement in locale project info and then we can close this. Alternatively I can also create a MR for the other issue that we backport and then revert this commit.

One test to be updated but otherwise this seems green. Also pushed a corresponding MR with just the changes against HEAD to #3594389: Remove unecessary core dev version replacement in locale project info.

Committed/pushed to 11.4.x, thanks!

Probably easier to do the rest of the follow-ups over on #3594389: Remove unecessary core dev version replacement in locale project info.

Restoring issue metadata.

Tagging this as a release highlight as representative of all the issues we completed in 11.4 of #3215707: [META] Modernize Locale module.

For sites with many languages, these issues didn't just do OOP refactoring but include considerable performance improvements for locale batch operations to check and import updated translations. It should be noted that this is mostly visible with *local* translation sources, as the HTTP requests still use the bulk of the time for now, but if you have 100 languages, I can imagine that you're using a workflow with local translation sources as a locale check would otherwise trigger 100 * 66 HTTP requests to drupal.org (I feel like we should think about an improvement for that, but that's a different topic) On a test site with 66 projects and 38 languages, on Drupal 11.3, drush locale:check takes 17.7s for me. On 11.4, it's 2.3s. In #3586654: Avoid scanning the file system for local po files, with a partial set of these changes, someone with 38 languages and 200 modules reported 7s instead of 5 minutes.