Problem/Motivation

With admin toolbar there was a toolbar item to toggle frontend editing. If using navigation module, this toolbar item is not available, because navigation module uses its own top bar plugins.

Steps to reproduce

Install frontend editing with navigation module. In frontend editing settings disable UI Toggle. See that no toggle is displayed in the toolbar.

Proposed resolution

Create a plugin to support navigation module.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

Status: Active » Needs review
hanan alasari’s picture

Assigned: Unassigned » hanan alasari
hanan alasari’s picture

Tested MR !168 locally on Drupal 10.6.2.

- Enabled navigation and navigation_top_bar.
- Confirmed frontend_editing is enabled.
- Set frontend_editing.settings:ui_toggle to false.
- Added access frontend editing and access navigation permissions.

Result:
- The Navigation top bar is active.
- The Frontend Editing toggle appears on frontend pages.
- The toggle can be switched on/off.
- State is preserved after reload.
- Editing worked on another tested node.

Manual test for the reported scenario works as expected.

One note: I also ran ToolbarToggleTest. The classic toolbar test passes, but the Navigation test fails locally because no .frontend-editing-toggle-link is rendered on /user/{id}. This may be core-version dependent; in my setup navigation_top_bar also had to be enabled, and the toggle was visible on frontend content pages.

hanan alasari’s picture

Status: Needs review » Reviewed & tested by the community
hanan alasari’s picture

Assigned: hanan alasari » Unassigned
a.dmitriiev’s picture

Adding some screenshots for before navigation module enabled:

Frontend Editing off

Frontend Editing on

and after:

Frontend Editing off

Frontend Editing on

a.dmitriiev’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.