Problem/Motivation

Remaining tasks

  1. The change record for this issue should include a link to recommendations page, https://www.drupal.org/node/3223395#s-shortcut. (For example, the CR for removing HAL)
  2. Tag this issue 'Needs release note.'
  3. Remove the extension ;-).
  4. Update update path tests as needed. See Learn how to write an automated update test.
  5. Remove references from core/phpstan-baseline.neon.
  6. Remove any spelling words specific to the extension from the dictionaries.
  7. Add the extension to the relevant removed list, either DRUPAL_CORE_REMOVED_MODULE_LIST or DRUPAL_CORE_REMOVED_THEME_LIST, in system.install.
  8. Check for references in @todo.

Release notes snippet

The Shortcut module has been removed from core, and can now be installed as a contrib module,

Issue fork drupal-3586214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16580

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Every single one of the fails seems to be this in upgrade tests :)

The link Continue was not found on the page.

Spotchecking with the search upgrade test result that is this requirements screen error on update.php. I assume other core update tests have some workaround for this that should be applied in the failing tests? :) (I don't know off the top of my head though :D)

Errors found
Removed core module
You must add the following contributed module and reload this page.
Shortcut
This module is installed on your site but is no longer provided by Core.

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed » Needs work
quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good removal.

Question are we going to do another fixture update once all these are removed ?

  • catch committed bc5de9c7 on main 
    task: #3586214 Remove the Shortcut module

By: quietone
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Question are we going to do another fixture update once all these are removed ?

Yes we should, otherwise contrib modules (and new core update tests) trying to write update tests based on the core fixtures will run into errors unless they add the workaround fixtures on top.

We either want to redo the fixtures with all the proposed removed modules and themes at once in advance, or wait until they're all done. My preference would be to do it in advance to simplify things for the individual issues but also wouldn't block issues like this on it.

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.