Problem/Motivation

This un-attributed commit https://git.drupalcode.org/project/modal_page/-/commit/01a90c0abc4eda1ac... capitalizes boolean and null values in the JavaScript files. While that's confirming to standards for PHP files, in JavaScript it makes the values appear to be undefined variables instead of boolean or null values.

Errors from mis-cased values

Steps to reproduce

Load any page that links to a modal where the site is running modal_page 5.1.11

Proposed resolution

Revert the offending commit, release an updated version of the 5.1.x. Maybe improve testing to identify this issue and check the functionality of the JS.

CommentFileSizeAuthor
Screenshot 2026-04-20 at 1.59.48 PM.png295.79 KBdhansen

Issue fork modal_page-3585849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dhansen created an issue. See original summary.

dhansen opened merge request !78

renatog’s picture

renatog commented

Nice catch @dhansen

Thank you so much for that

  • dhansen committed 5fea15f5 on 5.1.x 
    Fixing boolean and null value capitalizations in JS. Fixes #3585849
renatog’s picture

renatog commented
Status: Active » Fixed

committed in the dev branch

I'll generate a new release as soon as possible

Really appreciated your contribution

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

renatog’s picture

renatog commented

Released the new version with this fix

https://www.drupal.org/project/modal_page/releases/5.1.12

Added a public thanks for @dhansen in the release notes

Appreciated

renatog’s picture

renatog commented
Parent issue: » #3553252: Plan for the next Modal Releases

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.