Verify that Signal scenarios are implemented correctly

Reviewed the code to verify that Signal scenarios work as intended. Here are the findings:

1. The list of available Signal scenarios IS dynamic.

Signals::signalScenarios() in src/Signals.php iterates over all discovered CrowdsecScenario plugin definitions via the plugin manager. Any module can provide additional scenario plugins, and they will automatically appear in the Signal scenarios checkboxes on the settings form. Additionally, the SIGNAL_SCENARIO_LIST_BUILD event allows other modules to add or modify scenarios without implementing a full plugin.

If a module providing a scenario plugin is uninstalled, the scenario disappears from the list.

2. Only checked scenarios are signaled upstream.

Buffer::addSignal() in src/Buffer.php (line 158) performs a strict in_array() check against the signal_scenarios config value (which stores only the user's checked selections). Unchecked scenarios are logged as ignored and discarded before they reach the buffer or the upstream API.

3. Minor gap: no enable check for non-buffered plugins.

For buffered plugins (Whisper), Buffer::bufferSignal() checks the per-plugin enable setting before entering the leaky-bucket algorithm. However, for non-buffered plugins (Flood, Ban), the code path in ScenarioPluginBase::addSignal() goes directly to Buffer::addSignal() without checking enable. The signal is still filtered by the signal_scenarios check, so no incorrect signals are sent upstream, but unnecessary processing occurs for disabled non-buffered plugins.

Conclusion

The core behavior is correct. The only improvement would be adding the enable check for non-buffered plugins in ScenarioPluginBase::addSignal() to avoid unnecessary work.