CI: fix phpcs & phpstan issues
https://git.drupalcode.org/project/views_entity_form_field/-/pipelines/7...

Issue fork views_entity_form_field-3582075

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vladimiraus created an issue. See original summary.

vladimiraus opened merge request !23

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Active » Needs review
jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

looks good!
RTBC!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Left some final comments on the MR. Would be great to address that. Everything else looks fine to me!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Needs rebase

Needs rebase

byski’s picture

byski commented

Hi @vladimiraus would you mind if I picked this up? Happy to rebase the branch, address the review comment from @anybody, and coordinate with #3582727 on the deprecated function. Let me know if you'd rather finish it yourself.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Sure @byski, feel free.
It is a collaborative process.

jerech made their first commit to this issue’s fork.

jerech’s picture

jerech commented
Status: Needs work » Needs review

I've rebased the branch, resolved the conflicts, and addressed the PHPCS/PHPStan/stylelint issues. All pipelines are now passing and the issue is ready for review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Left some final comments. @vladimiraus will you do the final review and merge then?

jerech’s picture

jerech commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@jerech I left a further comment, please have a look.
@vladimiraus any additions? If everything is fine it would be great to have this merged to get CI green again and proceed in #3584683: Add test coverage

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@jerech are you planning to proceed here?

jerech’s picture

jerech commented

Of course I will; I’ll find some time today and I’ll do it

jerech’s picture

jerech commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice, -Needs rebase

Thanks @jerech LGTM. Let's proceed with #3584683: Add test coverage

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.