Better PHP Standards

There are some PHPSTAN issues to fix and the tests doesn't seem to be working

Hi @yusuf_khan did you test the functionality at all? I reviewed the functionality and it is not working at all now (please see attachment). Please review your code and make sure that the gif actually loads.

Hi @jeremy1606 did you test your changes as well? I'm getting this error when loading a page with a gif:

The website encountered an unexpected error. Try again later.

Drupal\Core\File\Exception\InvalidStreamWrapperException: in Drupal\Core\File\FileUrlGenerator->doGenerateString() (line 106 of core/lib/Drupal/Core/File/FileUrlGenerator.php).
Drupal\Core\File\FileUrlGenerator->generateAbsoluteString() (Line: 284)
Drupal\gifplayer\Plugin\Field\FieldFormatter\GifPlayerFormatter->viewElements() (Line: 91)
Drupal\Core\Field\FormatterBase->view() (Line: 83)
Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceFormatterBase->view() (Line: 275)
Drupal\Core\Entity\Entity\EntityViewDisplay->buildMultiple() (Line: 341)
Drupal\Core\Entity\EntityViewBuilder->buildComponents() (Line: 29)
Drupal\node\NodeViewBuilder->buildComponents() (Line: 283)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple() (Line: 240)
Drupal\Core\Entity\EntityViewBuilder->build()
call_user_func_array() (Line: 107)

I'm guessing the error is triggered from the line 284 at src/Plugin/Field/FieldFormatter/GifPlayerFormatter.php :

$img_cover = $this->fileUrlGenerator->generateAbsoluteString('base://' . $this->extensionListModule->getPath('gifplayer') . '/img/banana.png');

Thanks @jerech the WSOD is gone, I can see the banana.png file, but still unable to see the GIF at all, setting this to "Needs Work" again. I'll find some time to fix this later this week (screenshot attached)

Hi @yusuf_khan , thanks a lot, I tested your changes and it is working as expected, I also reviewed your code changes and found no issues. I'll merge this.

I created a new release with this: https://www.drupal.org/project/gifplayer/releases/2.0.5