I see that the module follows very old PHP standard practices, for example it doesn't follow the function return type hinting, among other features that need to be added
More information about Drupal's coding standards
Look into the module's source code, it is using outdated PHP practices.
Upgrade the module follow recent standard practices for writing more robust PHP code.
N/A
N/A
N/A
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
danrodComment #3
yusuf_khan commentedworking on it
Comment #5
yusuf_khan commentedplease review https://git.drupalcode.org/issue/languages_dropdown-3581165/-/tree/35811... -
@danrod Please review this branch , as im not sure which need to compared
Created merge request with coding standards improvements:
PHPCS: 0 errors
PHPStan: 0 errors
Added return type hints
Added dependency injection
The PHPUnit test failures are pre-existing and unrelated to these changes.
Comment #6
yusuf_khan commentedComment #7
danrodThe tests are failing, would you have some time to review?
Setting this to "Needs Work".
Comment #8
danrodComment #10
jerech commentedRefactored the module to support Drupal 11 hook attributes and PHPUnit 11 requirements. All functional tests are now passing, config schema issues are resolved, and code standards (PHPCS/PHPStan) are met. Ready for review.
Comment #11
danrodComment #12
danrodTested this on a D11 instance with a BS5 theme and works as expected, I'll move it to RTBC and backport it to 3.0.x.
Thanks a lot to everyone involved on this.
Comment #13
danrodComment #14
danrodComment #16
danrod