Closed (fixed)
Project:
Ban
Version:
1.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Mar 2026 at 13:20 UTC
Updated:
31 Mar 2026 at 09:40 UTC
Jump to comment: Most recent
Problem/Motivation
Add tugboat support for easier manual review and testing in issues
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork ban-3578788
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #5
grevil commentedLGTM!
Comment #6
grevil commentedComment #15
anybodyI was wondering why tugboat preview doesn't work as expected in #3427545: Allow bulk unbanning / removal and clearing ip addresses (Flush all) and doesn't seem to use the branch from the MR.
I guess the reason is, that the ban module doesn't have a composer.json yet?
See the related comments: https://www.drupal.org/node/3181987/discuss#comment-16507860
Comment #16
q0rban commentedThat would definitely do it, Julian! Without it, when Composer tries to read from the repo checkout, it can't find the composer.json, so then it falls back to using Packagist to pull from.
Comment #17
anybodyThank you so much for the quick reply @q0rban - sorry for coming to that conclusion late, because all other projects where I included Tugboat had a composer.json (or it failed).
Comment #20
grevil commentedDone, please review!
Comment #21
anybodyThanks @grevil! LGTM, but I'd like to wait for feedback from @mstrelan, especially because of #3578766: Ban 1.0 conflicts with composer requires for Drupal 10 and because I'm not totally sure which effects this will have for previous ban in core users.
I left a comment on the MR, maybe the requirement even helps with https://www.drupal.org/project/ban/issues/3578766#comment-16508815 - what would you prefer @mstrelan?
Without a composer.json tugboat in issues won't work as expected, see above. Still tugboat is absolutely optional, but helpful here.
Comment #22
anybodyThinking about this again, I'd vote to remove the core requirement. I think this is the wrong direction. But let's wait for @mstrelan's final feedback.
Comment #23
mstrelan commentedI'm not familiar with tugboat other than I get annoyed by the email notifications about tugboat builds on my MRs and think about all the resources used to build a preview that doesn't get used. It's probably helpful to some people, ideally would be a manual button to build it. Anyway I'm in favour of the composer.json, just a couple comments on the MR.
Comment #24
q0rban commentedThanks for the feedback on the Tugboat integration!
Hmm, I believe those are turned off. What project are you seeing them on?
If it makes you feel any better, Tugboat is very efficient at resource management. The containers are stopped until someone makes a request to them.
Keep in mind, the Tugboat Previews are there for anyone to be able to access, non-technical folks included. This means that folks that are interested in trying something out are clicking on the Preview without you knowing it.
While this functionality is built-in to Tugboat itself, it's not possible with the current d.o integration. We're working on fixing that, though, but as you might imagine, these things take time because there are a lot of moving parts.
Comment #25
mstrelan commentedMostly core, it looks like I haven't received one since some time last year, but Gmail groups them with other MR comments so they still appear in my inbox. Searching for "tugboat.qa" shows 203 threads. Sounds like that's no longer an issue though.
Comment #26
grevil commentedThat should be it!
Comment #27
anybodyThanks for the great feedback @q0rban! Tugboat is wonderful and of course I agree with the points made by @mstrelan. Super nice to get some direct feedback here.
Thanks for the fixes @grevil! RTBC!
Comment #28
anybodyMerged, thank you all! :)