Problem/Motivation

Once we have more site templates, the installer theme shows like this. On wide screens this pushes up the header and it mushes into the branding at the top.

Most breakpoints the spacing is really nice:

Wide breakpoint the headers mush tohether (also note the language picker assumes a less wide size than the matrix does, which looks odd too):

Steps to reproduce

Proposed resolution

User interface changes

Configuration changes

Issue fork drupal_cms-3578501

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy’s picture

I tried proposing a solution but can't quite figure this out unfourtunately. It looks like it is because cms-installer__header does not have a margin-block-end and also the 3rem top padding of .cms-installer__main overlaps with the header.

gábor hojtsy’s picture

Issue summary: View changes

pameeela made their first commit to this issue’s fork.

pameeela’s picture

Status: Active » Needs review

The language picker placement is based on the other screens in the installer having the wallpaper at those sizes. On the smaller sizes, you can see the wallpaper shows below. So we don't want to change this, it would create a situation where the picker is jumping around in the based on which step you are on.

Pushed a fix for the layout spacing, please give it a test!

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

Status: Needs review » Fixed

Merged 2.x and cherry-picked to 2.0.x and 2.1.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

gábor hojtsy’s picture

StatusFileSize
new281.64 KB

Nicely solved it for this page, thanks! It did change how other pages look though, eg. the site name screen looked different before, the form was lower on the screen:

I think the tradeoff is still better, just noting that there are other pages affected.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.