Problem/Motivation

We will heavily change the way we manage Instance entity history:

We need to prepare this change, reducing the gap by adding an abstraction. Good news, there is already some methods which are long expected in the project, so we can just add them now : HistoryInterface::getPast() & HistoryInterface::getFuture().

Proposed resolution

Once #3577791: Adopt Field API for Instance entity data is merged:

  1. Replace HistoryInterface::getCountPast() by ::getPast()
  2. Replace ::getCountFuture() by ::getFuture()
  3. Update LogsPanel
  4. Update tests

Issue fork display_builder-3578224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue tags: -display_builder-1.0.0-beta4 +display_builder-1.0.0-beta5
pdureau’s picture

pdureau commented
Title: Simplify LogsPanel by better using HistoryInteface » Better use of HistoryInteface in LogsPanel
pdureau’s picture

pdureau commented
Title: Better use of HistoryInteface in LogsPanel » Add ::getPast() & ::getFuture() to HistoryInterface
Issue summary: View changes

pdureau opened merge request !254

pdureau’s picture

pdureau commented
Status: Active » Needs review

Done. But kept on my side until #3577791: Adopt Field API for Instance entity data is merged

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33

mogtofu33 made their first commit to this issue’s fork.

  • mogtofu33 committed 88c678a0 on 1.0.x authored by pdureau 
    chore: #3578224 add getPast() and getFuture() to HistoryInterface

by:...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.