Problem/Motivation
Discovered while removing the deprecations #3574717: Remove deprecated code from migrate module in EntityContentBase when we make $entity_type_bundle_info required then it's an optional parameter in $account_switcher followed by a now required parameter.
Steps to reproduce
NA
Proposed resolution
Make $account_switcher also required
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3577140
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3577140-order-of-parameters
compare
- 3577140-migration-order
changes, plain diff MR !15007
Comments
Comment #2
smustgrave commentedComment #4
smustgrave commentedComment #5
benjifisherI think we can close this issue. See my comment #3574717-9: Remove deprecated code from migrate module. I gave the detailed explanation on that issue, not this one, so that the final review of that issue will see the explanation.
Comment #6
andypostI think it's more clear to have required params, did it in #3574717-10: Remove deprecated code from migrate module