Problem/Motivation

Constructor property promotion was added to \Drupal\file\Upload\FileUploadHandler in #3534589: Autowire services in file module
However, we are still setting the properties in the body of the constructor. This is unnecessary and should be removed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3577113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Issue summary: View changes

kim.pepper opened merge request !14988

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward to me.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Setting properties in FileUploadHandler is unnecessary » Setting properties in FileUploadHandler constructor is unnecessary
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

+1 the MR looks good overall and correctly simplifies the constructor.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed d1911787d5b to main and c289b697b0d to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed c289b697 on 11.x 
    task: #3577113 Setting properties in FileUploadHandler constructor is...

  • alexpott committed d1911787 on main 
    task: #3577113 Setting properties in FileUploadHandler constructor is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.