Problem/Motivation

After #3019851: Tabs should remain horizontal on desktop beyond a certain width has been fixed, you can notice that, when you have a big number of primary tabs with a width less or equal to 1100 pixels, tabs are not collapsed.

Steps to reproduce

Have many primary tabs and resize the browser width to 1100 pixels or less.

Screenshot

Proposed resolution

Separately check for primary and secondary tabs.

CommentFileSizeAuthor
#12 260304-1528.png21.08 KBavpaderno
#12 260304-1525.png22.85 KBavpaderno
#10 3575935-tab_shouldnt_remain_horizontal-9.patch823 byteschewie
Screenshot_20260226_132823.png69.45 KBchewie

Issue fork seven-3575935

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chewie created an issue. See original summary.

chewie opened merge request !244

chewie’s picture

chewie commented
Related issues: +#3019851: Tabs should remain horizontal on desktop beyond a certain width
chewie’s picture

chewie commented
Status: Active » Needs review
chewie’s picture

chewie commented
Status: Needs review » Needs work
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Tabs should not remain horizontal for primary tabs. » Tabs should not remain horizontal for primary tabs
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.1.x-dev » 2.0.x-dev
chewie’s picture

chewie commented

Added fix and adaptation for 11.3.x Drupal core.

chewie’s picture

chewie commented
Status: Needs work » Needs review
chewie’s picture

chewie commented
StatusFileSize
new 3575935-tab_shouldnt_remain_horizontal-9.patch823 bytes

I've added standalone patch for 2.0.0-beta2.

avpaderno opened merge request !251

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 260304-1525.png22.85 KB
new 260304-1528.png21.08 KB

This is how it appears before and after the merge request is applied.

screenshot

screenshot

  • avpaderno committed c6927b4a on 2.0.x 
    Issue #3575935: Tabs should not remain horizontal for primary tabs

  • avpaderno committed 22ab39b9 on main 
    Issue #3575935: Tabs should not remain horizontal for primary tabs
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.0.x-dev » 1.1.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Active

avpaderno changed the visibility of the branch 3575935-tabs-should-not to hidden.

avpaderno opened merge request !254

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

  • avpaderno committed 73e7a51d on 1.1.x 
    Issue #3575935: Tabs should not remain horizontal for primary tabs
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.