Problem/Motivation

StatementPrefetchIterator is only extended by SQLite Statement. StatementBase more recently became the base class for StatementInterface, and now there's no benefit to have an intermediate class in the inheritance hierarchy.

Proposed resolution

Adjust SQLite's Statement class to extend from StatementBase and deprecate StatementPrefetchIterator.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575547

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mondrake created an issue. See original summary.

mondrake’s picture

Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Needs work

Appears to need a rebase.

mondrake’s picture

Status: Needs work » Needs review

rebased

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Looks like a good rebase and good deprecation.

mondrake’s picture

Title: Deprecate StatementPrefetchIterator » [D12.1] Deprecate StatementPrefetchIterator
Status: Reviewed & tested by the community » Postponed

Postponed to when development of D12.1 will have started. See https://drupal.slack.com/archives/C079NQPQUEN/p1774611395145579 for discussion.

mondrake’s picture

bump

mondrake’s picture

Title: [D12.1] Deprecate StatementPrefetchIterator » Deprecate StatementPrefetchIterator
Status: Postponed » Reviewed & tested by the community

Rebased and bumped deprecation version to 12.1. Restoring RTBC as it was in #6.

  • catch committed 8582e13b on main
    task: #3575547 Deprecate StatementPrefetchIterator
    
    By: mondrake
    
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Not entirely sure, but this might be the first 12.1-only deprecation to land.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.