Problem/Motivation

This is not ready to be worked on. Currently in the FormBuilder when the deprecation is removed then csrf_token (not required) is followed by a required service. Which breaks a test.

Do we make csrf_token required or deprecate the order to move csrf_token to the end

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3574721

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Status: Active » Postponed

smustgrave opened merge request !14848

smustgrave’s picture

smustgrave commented
Status: Postponed » Needs review

Per the slack could we just make it required now? Credited larowlan and tim.plunkett from slack channel

nicxvan’s picture

nicxvan commented
Status: Needs review » Needs work

Callable resolver shouldn't be optional either

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

pushed that change though.

smustgrave’s picture

smustgrave commented
Issue tags: +Deprecation Removal
nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

This is good and matches what was discussed in slack.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Not clear if this should be backported to 11.3.x, I've only put it in main and 11.x for now - let me know if this needs to go back further.

Committed and pushed 0318f797cdf to main and e0b3be8edb2 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed e0b3be8e on 11.x 
    fix: #3574721 FormBuilder service order causes failure

By: smustgrave...

  • longwave committed 0318f797 on main 
    fix: #3574721 FormBuilder service order causes failure

By: smustgrave...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.