Problem/Motivation

Following on #3569829: Support farmOS 4, we can take advantage of the fact that we have dropped support for Drupal 9 and 10 by adopting some code modernization improvements, including:

- Constructor property promotion (see: https://php.watch/versions/8.0/constructor-property-promotion)
- Optional constructor docblock (see: #2140961: Allow constructor methods to omit docblocks)
- Autowiring (see: https://www.drupal.org/node/3218156)
- Hook classes (see: https://www.drupal.org/node/3486534)

Proposed resolution

Make the above improvements.

Remaining tasks

Open MR.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork farm_asset_termination-3573455

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

m.stenta created an issue. See original summary.

m.stenta opened merge request !7

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Active » Needs review

MR ready for review!

m.stenta’s picture

m.stenta
he/him
Primary language English
commented

Oh I forgot to say, this is based on the MR in #3569829: Support farmOS 4 so it includes those commits.

wotnak made their first commit to this issue’s fork.

wotnak’s picture

wotnak
he/him
commented
Status: Needs review » Reviewed & tested by the community

  • wotnak committed 2c1ead60 on 2.x authored by m.stenta 
    feat: #3573455 Code modernization improvements

By: m.stenta
By: wotnak
wotnak’s picture

wotnak
he/him
commented
Status: Reviewed & tested by the community » Fixed

Included in the v2.0.0 release.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.