Problem/Motivation

Time to remove the deprecated code from the block_content module :)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571874

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !14662

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Deprecation Removal

I didn't find anything to give feedback about. Everything deprecated for removal in D12 has been removed. This looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

One comment on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Not sure if I can go back to RTBC but think my problem before was I didn't remove enough of the hook, in this case the whole thing could go away. All green.

dcam’s picture

dcam commented
Status: Needs review » Needs work

Since I've leveled up my review of these issues I started this one again from scratch. I found one issue (below) and made one minor suggestion on the MR.

There are two lingering references to template_preprocess_block_content_add_list() in claro and stable9. The stable9 template is marked for removal in D12, so maybe it should be in-scope here. See https://git.drupalcode.org/project/drupal/-/blob/main/core/themes/claro/... and https://git.drupalcode.org/project/drupal/-/blob/main/core/themes/stable....

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks!

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Feedback was addressed. LGTM.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14662

  • catch committed ffea3237 on main 
    task: #3571874 Remove deprecated code from block_content

By: smustgrave...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.