Problem/Motivation

Fix the warnings/errors reported by PHP_CodeSniffer.

FILE: migrate_from_services/README.txt
------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 324 characters
 12 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
 37 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
 42 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: migrate_from_services/src/MigrateBatchExecutable.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  44 | ERROR | [ ] Missing member variable doc comment
  51 | ERROR | [ ] Missing member variable doc comment
 342 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: migrate_from_services/src/Form/MigrationExecuteForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 258 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 265 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------

Proposed resolution

Fix the warnings/errors reported by PHP_CodeSniffer.

NOTE: I would suggest enabling GitLab CI for the project, follow the Drupal Association .gitlab-ci.yml template and fix the PHP_CodeSniffer errors/warnings it reports.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml migrate_from_services/

Issue fork migrate_from_services-3571696

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

juandels3 created an issue. See original summary.

juandels3’s picture

juandels3 commented
Assigned: Unassigned » juandels3

juandels3 opened merge request !4

juandels3’s picture

juandels3 commented
Status: Active » Needs review

juandels3’s picture

juandels3 commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.