Problem/Motivation

Forms were originally created in the src directory, because I knew nothing. I've been moving them into better locations and this is continuing that work. This particular form shows a report of the members who have selected options on the registration form.

This is the last form still in the src/ directory, so moving this out is a minor milestone in the project.

Steps to reproduce

N/A

Proposed resolution

Because this form is part of the admin interface, it should be moved to the src/Form/Admin directory. It should also have a more descriptive class name, and be added to the build tests.

Remaining tasks

  • Move SimpleConregAdminMemberAddOnsinto src/Form/Admin.
  • Rename filename and class to "MemberAddOns".
  • Update conreg.routing.yml with the new form name.
  • In tests/src/Kernel/FormBuildTest.php, copy one of the existing test cases. Update the test function name, the route name, and make sure the default title match the one from the routing file, and the form ID check matches the form ID.
  • Verify new test passes.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork conreg-3571408

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lostcarpark created an issue. See original summary.

sourav_paul’s picture

working on this

sourav_paul’s picture

Status: Active » Needs review
StatusFileSize
new361.55 KB

Moved form into admin & created test.

SS:
img

Thanks...

lostcarpark’s picture

Status: Needs review » Reviewed & tested by the community

I have reviewed the changes, and carried out a manual test. It all looks good.

All the tests are passing, and PHPCS validates.

Moving to RTBC.

lostcarpark’s picture

Status: Reviewed & tested by the community » Fixed

Merged successfully.

Thanks for your effort on this. It's small but important step on the way to cleaning up the module.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.