Problem/Motivation

Remove all D12 deprecated code from the mentioned libraries.

Steps to reproduce

Proposed resolution

Remove all D12 deprecated code from the mentioned libraries.

Remaining tasks

Make sure tests are passing before review.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571054

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !14773

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

went down the rabbit hole for archiver but believe got everything.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

All of these removals look good. I grepped the affected three subdirectories of core/lib/Drupal/Core/ for "deprecat" and didn't find anything. I don't think there's anything more to do here.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Found a couple of bits that were missed, noted in the MR.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Addressed the feedback.

dcam’s picture

dcam commented

I think this was the last thing I reviewed before I went to bed last night and it shows. I'm glad @longwave caught it. I'm going to re-review the MR from scratch and see if I can do a better job.

Grep caught another mention of ArchiverManager in core/.deprecation-ignore.txt:

~/drupal_core$ grep -rn "ArchiverManager" core
core/.deprecation-ignore.txt:49:%Drupal\\Core\\Archiver\\ArchiverManager is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0. There is no replacement. See https://www.drupal.org/node/3556927%

And it caught other mentions of the service:

~/drupal_core$ grep -rn "plugin.manager.archiver" core
core/.deprecation-ignore.txt:48:%The "plugin.manager.archiver" service is deprecated in drupal:11.3.0 and is removed from drupal:12.0.0. There is no replacement. See https://www.drupal.org/node/3556927%
core/composer.json:127:        "ext-zip": "Needed to extend the plugin.manager.archiver service capability with the handling of files in the ZIP format."

The only other instances of the word "Archiver" are related to the ArchiveTar class. So I think we're good there.

I didn't find any other mention of removed classes or the hook.

Setting to Needs Work for the core/.deprecation-ignore.txt and core/composer.json edits.

dcam’s picture

dcam commented
Status: Needs review » Needs work
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks! Addressed those.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Composer test is failing and not 100% sure why just yet

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Fixed

dcam’s picture

dcam commented
Status: Needs review » Needs work

Your Composer changed the plugin API version in the lock file.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Applied the suggestion

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Looks good now. Let's roll with it.

catch closed merge request !14773

  • catch committed 78253dd1 on main 
    task: #3571054 Remove deprecated code from lib/Access, lib/Ajax, and lib...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.