Problem/Motivation

Currently the Administrative comment section of the views is a textarea field (allowing multiline values), however the schema defines it as a label, which has a Regex constraint that control characters such as new lines are not allowed.

Steps to reproduce

Create a view and edit the Administrative comment with a piece of multiline text.

Then inspect the view using the config inspector UI, under the Validation error section, you should see the following:

Labels are not allowed to span multiple lines or contain control characters.

Proposed resolution

Switch the config schema type from label to text.

Remaining tasks

Provide MR.

CommentFileSizeAuthor
#5 after.png31.56 KBangel_devoeted
#5 before.png37.58 KBangel_devoeted

Issue fork drupal-3570287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

Issue summary: View changes
Status: Active » Needs review
codebymikey’s picture

Issue summary: View changes
angel_devoeted’s picture

StatusFileSize
new37.58 KB
new31.56 KB

Reviewed and tested.

Confirmed the schema validation error for multiline display_comment and verified it is resolved with this change.

before
after

codebymikey’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @angel_devoeted, marking as RTBC in that case.

longwave’s picture

Version: main » 10.6.x-dev
Status: Reviewed & tested by the community » Fixed

Backporting to 10.6.x as an eligible bug fix.

Committed and pushed f2f5a52332d to main and 199e2bb684f to 11.x and c7129627d0e to 11.3.x and aa38b40afde to 10.6.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed aa38b40a on 10.6.x
    fix: #3570287 Use appropriate config schema for the Display comment (...

  • longwave committed c7129627 on 11.3.x
    fix: #3570287 Use appropriate config schema for the Display comment (...

  • longwave committed 199e2bb6 on 11.x
    fix: #3570287 Use appropriate config schema for the Display comment (...

  • longwave committed f2f5a523 on main
    fix: #3570287 Use appropriate config schema for the Display comment (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.