Problem/Motivation

The remaining functions in syslog.module are only used on a hook, let's deprecate them without replacement and move them to protected functions.

Steps to reproduce

Proposed resolution

Deprecate both without
Move to protected methods
There are also two unsupported modules from 6 and 7
I don't think it really warrants being api really if others disagree we can place it somewhere

Remaining tasks

Review
Confirm no replacement or not

User interface changes

Introduced terminology

API changes

syslog_facility_list is no longer API

Data model changes

Release notes snippet

Issue fork drupal-3570235

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Issue summary: View changes
mstrelan’s picture

Added two suggestions

nicxvan’s picture

Status: Active » Needs review
dcam’s picture

I was looking into the question of what to do about the contrib usage of syslog_facility_list(). I'm not seeing the usage in logger or extended_logger. They both have similarly-named class methods that came up in the search results. In fact logger has two identical methods duplicated in two forms. But I cloned both modules and grepped them just to be certain that syslog_facility_list isn't used. I didn't find anything. You might double-check your own results. We may not need to worry about this.

dcam’s picture

Status: Needs review » Needs work

That same docblock references a function that doesn't exist anymore. I left a suggestion to fix it.

nicxvan’s picture

You're right, I just double checked.

Needs work for updating the IS and your comment on documentation.

There is also an open question about deprecation versions.

nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Issue summary: View changes
Status: Needs work » Needs review

I also applied your suggestion and updated the issue summary.

dcam’s picture

Status: Needs review » Reviewed & tested by the community

My feedback was addressed. This looks good to me.

longwave’s picture

Status: Reviewed & tested by the community » Needs review

Added a question.

nicxvan’s picture

I converted it to a config_target, good suggestion!

dcam’s picture

Status: Needs review » Reviewed & tested by the community

It was a good suggestion. It's always nice to simplify code.

I did a manual test of the form after applying the latest changes. The config targets work properly. The syslog.settings configuration continues to be updated by the form. The deprecation notice for the former submit function has been updated to note that it is now deprecated without replacement. This looks good.

longwave’s picture

Status: Reviewed & tested by the community » Needs work

config_target should set default_value automatically, which means we can drop even more code!

nicxvan’s picture

Oh I didn't know that!

That will be a nice cleanup.

nicxvan’s picture

Assigned: Unassigned » nicxvan
nicxvan’s picture

Assigned: nicxvan » Unassigned
Status: Needs work » Needs review
dcam’s picture

Status: Needs review » Reviewed & tested by the community

I forgot all about it too. I don't write enough forms these days.

All of the #default_value keys have been removed and the config is no longer loaded by the form, simplifying it even further. I did another manual test of the form and it continued to update the config values correctly. LGTM.

longwave’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4dcc7892403 to main and ad10a2e50e0 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed ad10a2e5 on 11.x
    refactor: #3570235 Deprecate functions in syslog.module
    
    By: nicxvan
    By...

  • longwave committed 4dcc7892 on main
    refactor: #3570235 Deprecate functions in syslog.module
    
    By: nicxvan
    By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.